Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add monorepo tools #9196

Merged
merged 1 commit into from
Dec 24, 2024
Merged

chore: add monorepo tools #9196

merged 1 commit into from
Dec 24, 2024

Conversation

forehalo
Copy link
Member

No description provided.

@github-actions github-actions bot added docs Improvements or additions to documentation mod:component app:electron Related to electron app mod:dev app:core labels Dec 18, 2024
@forehalo Graphite App
Copy link
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 18, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a48b654. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 18, 2024
View reviewed changes
tools/utils/src/process.ts Fixed Show fixed Hide fixed
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.28090% with 133 lines in your changes missing coverage. Please review.

Project coverage is 51.76%. Comparing base (3a8d90d) to head (3a6d17b).
Report is 11 commits behind head on canary.

Files with missing lines Patch % Lines
tools/utils/src/workspace.ts 2.98% 65 Missing ⚠️
tools/utils/src/process.ts 2.50% 39 Missing ⚠️
tools/utils/src/logger.ts 6.66% 14 Missing ⚠️
tools/utils/src/package.ts 75.67% 8 Missing and 1 partial ⚠️
tools/utils/src/path.ts 66.66% 4 Missing ⚠️
tools/utils/src/build-config.ts 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           canary    #9196      +/-   ##
==========================================
- Coverage   51.84%   51.76%   -0.09%     
==========================================
  Files        2137     2146       +9     
  Lines       97420    97618     +198     
  Branches    16645    16328     -317     
==========================================
+ Hits        50506    50528      +22     
- Misses      45553    45774     +221     
+ Partials     1361     1316      -45
Flag Coverage Δ
server-test 78.17% <ø> (+0.02%) ⬆️
unittest 30.86% <25.28%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo force-pushed the 61/monorepo-tools branch 2 times, most recently from ad3f492 to 57979a7 Compare December 19, 2024 04:06
@github-actions github-actions bot added the test Related to test cases label Dec 19, 2024
@forehalo forehalo force-pushed the 61/monorepo-tools branch 3 times, most recently from 65880f0 to ebc4d0e Compare December 19, 2024 10:17
@forehalo forehalo force-pushed the 61/monorepo-tools branch 4 times, most recently from ed1ca53 to d2ffc78 Compare December 20, 2024 03:50
@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:i18n Related to i18n labels Dec 20, 2024
@forehalo forehalo force-pushed the 61/monorepo-tools branch 10 times, most recently from 54b145f to f4f7cf1 Compare December 23, 2024 10:24
@forehalo Graphite App
Copy link
Member Author

Merge activity

  • Dec 23, 7:57 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

pengx17
pengx17 reviewed Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please list the improvements of the new monorepo tool?

@forehalo forehalo force-pushed the 61/monorepo-tools branch 2 times, most recently from 43d1f07 to f0d89c7 Compare December 24, 2024 03:45
@forehalo Graphite App
Copy link
Member Author

Can you please list the improvements of the new monorepo tool?

there is a simple readme at tools/cli/README.md for it and I will add more detail once it become more stable. this PR is going to be bigger

@forehalo forehalo merged commit 2443935 into canary Dec 24, 2024
60 checks passed
@forehalo forehalo deleted the 61/monorepo-tools branch December 24, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkskygit darkskygit darkskygit left review comments

@pengx17 pengx17 pengx17 left review comments

@EYHN EYHN EYHN approved these changes

@JimmFly JimmFly Awaiting requested review from JimmFly

@CatsJuice CatsJuice Awaiting requested review from CatsJuice

@Brooooooklyn Brooooooklyn Awaiting requested review from Brooooooklyn

Assignees
No one assigned
Labels
app:core app:electron Related to electron app app:server docs Improvements or additions to documentation mod:component mod:dev mod:i18n Related to i18n mod:infra Environment related issues and discussions mod:native mod:server-native test Related to test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@forehalo @pengx17 @EYHN @darkskygit